JPEXS Free Flash Decompiler Issue Tracker

Sorry I just realized I generated "jpexs_export_v1697.txt" incorrectly. Please, use "jpexs_export_v1697_correct.txt" instead of that one.

Please try the latest nightly version. then in advanced settings/Export uncheck the incluse character id in export file name setting. Now i have only the real diffrences. Is it ok for you?

Ok, I've been doing some tests and this is what I found: * Using command-line (like I said I was using in the main report): Either checking or unchecking the new setting is NOT getting me a diff-friendly output. In fact, and this probably deserve a new bug report, ***but I'm getting more AS files from command-line export than UI export!!!*** * Using UI (selecting "scripts" and exporting selection): Either checking or unchecking the new setting is getting me a diff-friendly output (like you tested I guess) ***BUT I'm missing some AS files!!!*** :'( You can try it yourself, I've reproduced the 2 different export like this: Commandline: ffdec_4.0.5_nightly366\ffdec.bat -export script export_cmd366_1696 ATG_-_Reconstruction.v1696.swf >nul UI: selected "scripts" folder and clicked "export selection" For me, command-line export has an output of 5962 files, 993 folders and UI export an output of 5035 files, 532 folders. Comparing the outputs I found out that most (if not all) "DoAction" of "DefineSprite" were missing from UI export (see in the attached image how the "export" option is greyed out for the selected item, although It did get exported from CMD) I'm getting the following in stderr, but I'm getting the same errors both in CMD and UI, so I guess that's not the reason of the missing objects: Jan 21, 2015 2:01:27 AM com.jpexs.decompiler.flash.action.ActionGraphSource adr2pos SEVERE: Address loc12518 not found Jan 21, 2015 2:01:27 AM com.jpexs.decompiler.flash.action.swf4.ActionIf getBranches SEVERE: Invalid IF jump to ofs12518 Jan 21, 2015 2:01:27 AM com.jpexs.decompiler.flash.action.ActionGraphSource adr2pos SEVERE: Address loc12518 not found Jan 21, 2015 2:01:27 AM com.jpexs.decompiler.flash.action.swf4.ActionIf getBranches SEVERE: Invalid IF jump to ofs12518

more AS files from command-line export than UI export: fixed now the UI ans command line exports exaclty the same files. Please try it. SEVERE: Address loc12518 not found (+ other 3) is a decompilation problem. Please create new issue if you want them to be fixed. JPEXS will fix them later.

The commandline/UI fix is great, now I'm getting the same results from both methods. As for the "diff friendly" output, it's almost there, this is what I've seen so far: * Removing IDs does generate a perfect diff, but the lost of IDs is a big deal for me, since all I can't tell easily which parts are related to each other. * Not removing IDs, generates a quite "diff friendly" output already, but like I said before, some objects get reordered and screw the diffs. It needs some tweaking. Since I had some free time (and I didn't want to bother you more than I already did :P), I decided to see code if I could come out with a solution (quite bold on my part :P as I'm not a Java dev and my knowledge about Flash internals is almost non-existant :P). But I think I found something that may be useful: Looking exported AS files and the objects in the tree generated by the FFdec GUI for the 'ATG_-_Reconstruction.v1697.swf' file, I noticed the following: * the unordered objects were coming from objects with same IDs. (look at "multiplesAS_sameIDs.png") * when exporting these files, the code add a secuential number at the end of the filename to differentiate them (like "on(release)_1.as"), first come first served, so I guess this is what is scrambling the objects (see "code_that_adds_secuential_IDs.png") * all the objects that are sharing IDs and generating a non-friendly diff output are "PlaceObjects" * all PlaceObjects with the same IDs, have different "Depth" (look at "PlaceObject2_depth.png", for those particular objects, the depths are 7, 12 and 17) After a while I got curious about this depth attribute (I guess you or jpexs probably already know about it, but I didn't), In this page: http://www-lehre.inf.uos.de/~fbstark/diplom/docs/swf/DisplayList.htm it says: "The depth value determines the stacking order of the character. Characters with lower depth values are displayed underneath characters with higher depth values. A depth value of 1 means the character is displayed at the bottom of the stack. There can be only one character at any given depth. This means a character that is already on the display list can be identified by its depth alone. (i.e. a CharacterId is not required)." So I guess it would help to generate a sortable Unique ID between the different instances of these PlaceObjects. So I added 3 lines of code in CharacterIdTag.getExportFileName() (see "code_changed.png") to generate directories like "PlaceObject_ID_DEPTH" instead of just "PlaceObject_ID", and after sorting the code by object types + IDs (which I get from the file structure), now I'm getting diff like I wanted (showing only the real changes). Doing a diff of "export_modified_ffdec_1696.txt" "export_modified_ffdec_1697.txt" (which are just a concatenation of the exported files, sorted by name + ID), both generated by the modified version of ffdec, show only the real changes. It "works for me"(TM) and "at least for this case"(TM), but I guess you are savvy enough to check if this is a good idea/valid solution and implement it correctly if necessary. Quite a long comment, it's 1AM and I'm sleepy, English isn't my native language, so I'm praying I made myself clear :P

Ok, It is a good idea. I added the depth to the export file name (and to the tree nodes in the GUI, too) And removed the "Removing IDs" setting, because it was only added for you, and you don't need it anymore. I hope you don't mind. Please try the latest nightly

I tested it with multiple versions game and it's working great. You can close this. Thanks for your help.